search

airshipit / vino

Apache License 2.0
1 stars 1 forks source link

Pin sushy-tools image #10

Open mattmceuen opened 3 years ago

mattmceuen commented 3 years ago

Today, vino (as well as airship-in-a-pod) make use of the quay.io/metal3-io/sushy-tools image, which unfortunately does not get tagged aside from latest. This is problematic, and could lead to unexpected/untested behavior.

This issue is to pin to a particular SHA value of the image (the most recent one, unless there's reason not to). A comment should be left above the image spec that notes down the date that corresponds to the SHA.

The same SHA/comment should be added to the Treasuremap versions yaml as part of this story as well.

sshiba commented 3 years ago

Please, assign this issue to me. Thanks.

sshiba commented 3 years ago

Two patchsets created to address this issue:

sshiba commented 3 years ago

Vino: https://review.opendev.org/c/airship/vino/+/799326 passed +1 Zull and is ready for review. Treasuremap: https://review.opendev.org/c/airship/treasuremap/+/799325 failed Zull so rechecked.