search

airsonic / airsonic

:satellite: :cloud: :notes:Airsonic, a Free and Open Source community driven media server (fork of Subsonic and Libresonic)
https://airsonic.github.io
GNU General Public License v3.0
2.01k stars 237 forks source link

Scope of LocaleResolver #748

Closed tesshucom closed 5 years ago

tesshucom commented 6 years ago

Problem description

Request may or may not pass through LocaleResolver.

Steps to reproduce

->For example, Biography of LastFM

Rest access to LastFM refers only to the language setting of "Personal". Therefore, depending on the setting of "General", even users who are displaying other than English, there is an operation case "Display only in LastFM in English".

(It should be explicitly specified by "Personal")

591

tesshucom commented 6 years ago

Since Service refers to personal locale, use LocaleResolver created for this.

ex) before

1)General English, Personal (Default) -> bio = English 2)General English, Personal Japanese -> bio = Japanese 3)General Japanese, Personal (Default) -> bio = English 4)General Japanese, Personal Japanese -> bio = Japanese

after

1)General English, Personal (Default) -> bio = English 2)General English, Personal Japanese -> bio = Japanese 3)General Japanese, Personal (Default) -> bio = Japanese 4)General Japanese, Personal Japanese -> bio = Japanese

3) The case differs. If the user does not do anything with Pesonal, it will take over the value set in General instead of Eng fixed