[Bug] Call of an undefined run function

airspeed-velocity / asv

Airspeed Velocity: A simple Python benchmarking tool with web-based reporting

https://asv.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

860 stars 180 forks source link

[Bug] Call of an undefined run function #1020

Open dorothykiz1 opened 2 years ago

dorothykiz1 commented 2 years ago

There is a run() function being called in the asv/benchmark.py however it's not defined.

Fixing this will require you to first define the function before being used.

To reproduce the bug, run:

pip install flake8
flake8 --max-line-length=99 asv/benchmark.py(this will ignore the max line length according to flake8 from the standard limit of 79 to 99)

datapythonista commented 2 years ago

Can you clarify the description and title of this please? It's not clear what is the problem, and what needs to be done to fix this problem. Steps on how to reproduce the bug are also very useful to help understand better what you're reporting here.

LucyJimenez commented 2 years ago

@datapythonista @dorothykiz1 I repeated the steps to generate the bug and found no error. Is it possible that this has already been fixed?

HaoZeke commented 1 year ago

The bug is still present, it is just silenced. Probably should be profile.run or self.run https://github.com/airspeed-velocity/asv/blob/15075b76557e01758e4a561a39e3fdfc78a4e1d3/asv/benchmark.py#L472-L474C18