search

airspeed-velocity / asv

Airspeed Velocity: A simple Python benchmarking tool with web-based reporting
https://asv.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
862 stars 180 forks source link

Remove mercurial plugin #1203

Open datapythonista opened 2 years ago

datapythonista commented 2 years ago

Is any project using asv still using mercurial? The library powering the plugin is unmaintained (see #1138), the mercurial code is causing some problems and warnings in the CI, and I'm not sure if anyone will still be using it.

If removed, projects using mercurial should ideally still be able to use asv, but only for the working directory, and they should manage the commit checkout externally to asv. I think few changes are required for this to work.

saaj commented 2 years ago

I use it for https://heptapod.host/saajns/procpath. I didn't have issues with asv and Mercurial. So I'm happy with the integration as is, hence would prefer s/Remove/Extract/ as discussed in the linked issue.

mattip commented 1 year ago

I don't understand what "extract" would look like. Which issue dsicussed that?

saaj commented 1 year ago

Which issue dsicussed that?

From OP's https://github.com/airspeed-velocity/asv/issues/1138#issuecomment-1066649035:

Personally, I would move mercurial stuff to a third party project [...] I'd also move git functionality to a third party [...] I'd better have a much smaller asv core project that can be maintained very easily, and other things as plugins/separate projects.