Fix mamba environment option

airspeed-velocity / asv

Airspeed Velocity: A simple Python benchmarking tool with web-based reporting

https://asv.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

845 stars 177 forks source link

Fix mamba environment option #1370

Closed dstansby closed 5 months ago

dstansby commented 5 months ago

I'm attempting to fix https://github.com/airspeed-velocity/asv/issues/1353. Currently this involves:

adding some extra docs
adding an import guard to check that libmambapy is installed
making the mamba plugin discoverable by asv (by importing it in plugins.__init__.py)

However, I'm not convinced the mamba option has ever worked... The mamba Python API does not contain mamba.api.MambaSolver(), which was added as an import in https://github.com/airspeed-velocity/asv/pull/1238. @HaoZeke do you know any more about this import and what package needs to be installed to access it?

HaoZeke commented 5 months ago

@HaoZeke do you know any more about this import and what package needs to be installed to access it?

I will take a closer look after next week (am traveling). It was certainly available at the time of that PR, though libmambapy has changed quite a bit over the past year or so.

HaoZeke commented 5 months ago

So there used to be a mamba.api which shipped a default implementation of MambaSolver as noted in an older fork. It was removed in December of 2023. However it has been removed so I'll setup a different default implementation for us (boa moves far too quickly and is too heavy to be a dependency).

HaoZeke commented 5 months ago

Closing in favor of #1372 and #1373.

dstansby commented 5 months ago

Fab, thanks for picking this up!