search

airspeed-velocity / asv

Airspeed Velocity: A simple Python benchmarking tool with web-based reporting
https://asv.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
866 stars 181 forks source link

MAINT: Switch to 3.8 #1380

Closed HaoZeke closed 7 months ago

HaoZeke commented 7 months ago

Closes #1318 and https://github.com/airspeed-velocity/asv_runner/issues/28

mattip commented 7 months ago

The disadvantage to this is that projects who wish to reproduce results for 3.7 can no longer do so. Are there features from higher version pythons that asv wants to utilize? If not then I think we should reject the issue. I am not sure what you meant by (from the issue)

3.8 would require significant rewrites to the test suite.

I don't see significant rewrites here ...

HaoZeke commented 7 months ago

The disadvantage to this is that projects who wish to reproduce results for 3.7 can no longer do so. Are there features from higher version pythons that asv wants to utilize? If not then I think we should reject the issue. I am not sure what you meant by (from the issue)

3.8 would require significant rewrites to the test suite.

I don't see significant rewrites here ...

I've been careful to not use any features beyond 3.7, so we can reject this (though I will need to slightly modify the documentation workflow for asv_runner, the myst parser needs 3.8).

Turns out the test suite issue was a bit of a red herring.

HaoZeke commented 7 months ago

I'm going to go ahead and close this for now.