search

airspeed-velocity / asv

Airspeed Velocity: A simple Python benchmarking tool with web-based reporting
https://asv.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
866 stars 181 forks source link

REL: Fix windows wheels #1383

Closed HaoZeke closed 7 months ago

HaoZeke commented 7 months ago 
Run pypa/cibuildwheel@v2.15.0
Run actions/setup-python@v4
Installed versions
Run pipx run --python "C:\hostedtoolcache\windows\Python\3.11.7\x64\python.exe" --spec "D:\a\_actions\pypa\cibuildwheel\v2.15.0" cibuildwheel "." --output-dir '"wheelhouse"' --config-file '""' --only '""'
Invalid --only='""', must be a build selector with a known platform
creating virtual environment...
creating virtual environment...
determining package name from 'D:\\a\\_actions\\pypa\\cibuildwheel\\v2.15.0'...
installing cibuildwheel from spec 'D:\\a\\_actions\\pypa\\cibuildwheel\\v2.15.0'...
Error: Process completed with exit code 1.

..

HaoZeke commented 7 months ago

Maybe for the next release

mattip commented 7 months ago

I was seeing this in the scipy builds as well. I am trying an update to cibuildwheel’s version

HaoZeke commented 7 months ago

I was seeing this in the scipy builds as well. I am trying an update to cibuildwheel’s version

Awesome, then in that case since it seems to be something which might be fixed in the near future I'll just delete the tag and wait to get it in 0.6.2 (luckily didn't publish to PyPI yet)

mattip commented 7 months ago

According to https://github.com/pypa/cibuildwheel/issues/1748, this is fixed in cibuildwheel 2.16.5.

HaoZeke commented 7 months ago

According to pypa/cibuildwheel#1748, this is fixed in cibuildwheel 2.16.5.

Yup, I think it should work, have a run now: https://github.com/airspeed-velocity/asv/actions/runs/7870830392

I thought upgrading to v4 for upload-artifact and download-artifact would be a good idea but it needs some migration https://github.com/actions/upload-artifact/issues/478 (hence the new run).

HaoZeke commented 7 months ago

Done! Release is live too, downloaded the artifacts from the run and used twine upload to put them on PyPI.

Also on Github.