search

airspeed-velocity / asv

Airspeed Velocity: A simple Python benchmarking tool with web-based reporting
https://asv.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
860 stars 180 forks source link

Adding "benchmark" to matrix breaks output #819

Open saraedum opened 5 years ago

saraedum commented 5 years ago

I am using the benchmark package from conda-forge in my setup. Unfortunately, adding "benchmark" : [] to my matrix in asv.conf.json breaks the published HTML pages. It seems that the name of the actual benchmarks is then filtered against the values of that key and since that [] is empty, all benchmarks are dropped.

As a workaround, I can set "benchmark==1.4.1": []. But should there be a warning that the matrix contains reserved keywords?

I am happy to attempt to fix this but I would like to know whether people agree that something could be wrong here.

pv commented 5 years ago

The problem seems to be only on the javascript side, on the dealing with the hash-query string here:

https://github.com/airspeed-velocity/asv/blob/b67ee459b0d7ec719c9ab14c3edeb2d3e56381b0/asv/www/graphdisplay.js#L1355-L1414

and then in the place that sets the query string:

https://github.com/airspeed-velocity/asv/blob/b67ee459b0d7ec719c9ab14c3edeb2d3e56381b0/asv/www/graphdisplay.js#L429-L440