search

airspy / airspyone_host

AirSpy's usemode driver and associated tools
http://airspy.com
247 stars 88 forks source link

Can three additional functions be added to libairspy #46

Closed ghost closed 2 years ago

ghost commented 6 years ago

airspy_get_lna_gain airspy_get_mixer_gain airspy_get_vga_gain ref: https://github.com/pothosware/SoapyAirspy/pull/14#issuecomment-351199121

bvernoux commented 6 years ago

I do not understand such requirement as such value comes from the user which call the airspy_set_xxx so it shall be saved locally .and reused later without the need to add such API in libairspy

ghost commented 6 years ago

The problem is if you call airspy_set_linearity_gain (or airspy_set_sensitivity_gain) is that it modifies the lna, mixer and vga gains, now the client software is keeping track of them also but they have been modified, and it has no idea what they are currently. Another workaround would be to fully duplicate this lookup table: https://github.com/airspy/airspyone_host/blob/master/libairspy/src/airspy.c#L117 in SoapyAirspy so that it would know the current values of the three gains, but that seems redundant.

bvernoux commented 6 years ago

Thanks for the clarification I have not checked that aspect in that case we could add such APIs in libairspy any contribution is welcome (but it shall not require to modify the firmware)

bvernoux commented 2 years ago

This issue is old and I have no time to work on it, so it is closed If anyone is interested you are welcome to do a Pull Request