airswap / airswap-protocols

AirSwap DEX and DAO Smart Contracts and Developer Tools

https://about.airswap.io/

MIT License

233 stars 95 forks source link

Use EIP712s hashTypedData functions #1306

Closed k06a closed 3 months ago

openzeppelin-code[bot] commented 7 months ago

Use EIP712s hashTypedData functions

Generated at commit: 556818daad2788898268def2dac141f5c0690ea8

🚨 Report Summary

Severity Level Results

Contracts Critical
High
Medium
Low
Note
Total 1
1
0
7
24
33

Dependencies Critical
High
Medium
Low
Note
Total 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	1 1 0 7 24 33
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

dmosites commented 6 months ago

Thanks. This could also be used on SwapERC20.sol:L260? https://github.com/airswap/airswap-protocols/pull/1306/files#diff-a1ad63b6dfc142aa0e9d5894dd4d55c81fadc2bd1a98318b964be3c84c91aae7L260

k06a commented 6 months ago

@dmosites true

dmosites commented 3 months ago

Implemented in #1318 thank you @k06a