airswap / airswap-protocols

AirSwap Contracts and Tools

https://about.airswap.io/

MIT License

231 stars 94 forks source link

Use of hashTypeData for code clarity and check chain ID #1318

Closed smartcontrart closed 2 months ago

openzeppelin-code[bot] commented 4 months ago

Use of hashTypeData for code clarity and check chain ID

Generated at commit: b9b7ecf5905a251afee510d82865f7a15e80f270

🚨 Report Summary

Severity Level Results

Contracts Critical
High
Medium
Low
Note
Total 1
1
0
7
25
34

Dependencies Critical
High
Medium
Low
Note
Total 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	1 1 0 7 25 34
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

dmosites commented 2 months ago

Please remove ChainIdChanged from the interfaces and reduce MAX_ERROR_COUNT by one.