airwallex / airwallex-payment-android

Airwallex PA Android SDK
MIT License
14 stars 12 forks source link

[MOB-1038] Google pay update billing and naming #64

Closed aw-hector closed 2 years ago

aw-hector commented 2 years ago

This Pr is to clear up following chores before Google Pay release:

  1. Make first/last name empty string if can't get it from name response from google pay api
  2. Move billing info inside payment method field in confirm intent request
  3. Hardcode expiry year with 20 (align with web) as backend needs full YYYY digits.
  4. Use country code as city if locality is missing from google pay api
  5. Enable and add Readme for Google Pay module
github-actions[bot] commented 2 years ago

Unit Test Results

225 tests  +4   225 :heavy_check_mark: +4   1m 17s :stopwatch: +5s   95 suites ±0       0 :zzz: ±0    95 files   ±0       0 :x: ±0 

Results for commit 6d85739d. ± Comparison against base commit 886a4a64.

This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both. ``` com.airwallex.android.core.model.PaymentMethodRequestTest ‑ testSetGooglePayPaymentMethodRequest ``` ``` com.airwallex.android.core.model.PaymentMethodRequestTest ‑ testCardPaymentMethodRequest com.airwallex.android.core.model.PaymentMethodRequestTest ‑ testGooglePayPaymentMethodRequest com.airwallex.android.googlepay.PaymentsUtilTest ‑ test getBilling city when locality is empty com.airwallex.android.googlepay.PaymentsUtilTest ‑ test getBilling when name does not have space com.airwallex.android.view.CardExpiryEditTextTest ‑ testValidDateFields ```

:recycle: This comment has been updated with latest results.