search

airwallex / paymentacceptance-plugin-magento

Airwallex payment magento plugin
12 stars 3 forks source link

Feature/mb 17578 #7

Closed laurisdedumets closed 2 years ago

laurisdedumets commented 2 years ago

Recreated pull request #6, as the branch accidentally got removed while fixing the forked repository.

From @roy-klopper-awx: Can you take a look at the timezone calculation based on the timezone? Are there perhaps Magento native objects we can use to do lifetime calculations? Can we set the timezone according the the platforms settings? I can imagine this would cause issues for people using different timezones.

Re: The new commit retrieves the timezone from the token that the request to the Airwallex authorization API returns, creating a new DateTime object with the same timezone as the token returned. There is no point in adding Magento timezones into this calculation, as all we care about at this point is the lifetime, not the specific time inside the Magento instance.

MagebitProjects commented 2 years ago

Merged pull request without review after approval by Snow Jiang.

Snow-Jiang commented 2 years ago

Hi @roy-klopper-awx

I have asked the Magebit team to release it since this is an urgent task that should have been completed weeks ago.

This is now available for Composer-based installs, let us know if you find any issues or have any concerns still.

Cheers Snow