search

airy10 / esphome-m5stickC

esphome components for the M5StickC
81 stars 75 forks source link

version of espHome #12

Open noxqs opened 3 years ago

noxqs commented 3 years ago

It is worth noting the required version of espHome is 1.16.2 due to the color.to_rgb_565 requirement. Both dev and latest have this removed.

IceSocket commented 3 years ago

This makes the ESPHome Water Leak Sensor un-compilable in Home Assistant.

src/esphome/components/st7735/st7735.cpp: In member function 'virtual void esphome::st7735::ST7735::draw_absolute_pixel_internal(int, int, esphome::Color)': src/esphome/components/st7735/st7735.cpp:275:25: error: 'struct esphome::Color' has no member named 'to_rgb_565' auto color565 = color.to_rgb_565(); ^ *** [/data/water_leak_01/.pioenvs/water_leak_01/src/esphome/components/st7735/st7735.cpp.o] Error 1 ========================== [FAILED] Took 5.49 seconds ==========================

crowbarz commented 3 years ago

I tried to fix this in #13 by updating the color.to_rgb_565() call per esphome/esphome#1551.

It turns out though that the m5stickC plus that I have uses a st7789v2 screen and not a st7735, so I can't actually test the PR.

IceSocket commented 3 years ago

Confirming fix working for original M5StickC also. Great work, big thanks!