Channels.connect endpoint requires a token parameter which is not needed for connecting a chatplugin channel

airyhq / airy

💬 Open Source App Framework to build streaming apps with real-time data - 💎 Build real-time data pipelines and make real-time data universally accessible - 🤖 Join historical and real-time data in the stream to create smarter ML and AI applications. - ⚡ Standardize complex data ingestion and stream data to apps with pre-built connectors

https://airy.co/docs/core

Apache License 2.0

369 stars 44 forks source link

Channels.connect endpoint requires a token parameter which is not needed for connecting a chatplugin channel #378

Closed pascal-holy closed 3 years ago

pascal-holy commented 3 years ago

curl -H "Content-Type: application/json" -H "Authorization: $token" -d \
"{ \
    \"source\": \"chat_plugin\", \
    \"source_channel_id\": \"my-chat-channel-1\", \
    \"name\": \"chat plugin source\"   
}" api.airy/channels.connect

{"timestamp":1606291874857,"status":400,"error":"Bad Request","message":"","path":"/channels.connect"}%

lucapette commented 3 years ago

Nice catch, I think we should make it required depending on the source? I'm not sure how comfortable the code would look like (but conditionally requiring fields by source is what makes most sense from a user perspective as far as I can say)