aisamanra / s-cargot

Elaborate and expressive S-Expression library for Haskell
Other
61 stars 6 forks source link

Add support for source locations #7

Closed ckoparkar closed 7 years ago

ckoparkar commented 7 years ago

I've used the simplest solution from the ones described in this Reddit thread. I wanted to hear your thoughts about this whole thing, so I opted not to change too much right now. Also, adding printers for the located parsers is another TODO, which I can tackle if we decide to merge this.

ckoparkar commented 7 years ago

Hey @aisamanra, have you had a chance to look at this ?

aisamanra commented 7 years ago

Oh wow, I'm so sorry I left this waiting for so long! This is an excellent change both in content and implementation—thank you so much for doing it!

ckoparkar commented 7 years ago

Ah, no problem. Glad it's merged!