aisayko / Django-tinymce-filebrowser

Simple django-based file uploader and viewer for TinyMCE
MIT License
35 stars 32 forks source link

Cannot import mce_filebrowser.urls #19

Open alamkaton opened 5 years ago

alamkaton commented 5 years ago

I followed your installasion guide, I typed this: urlpatterns = [ ... url(r'^tinymce/', include('tinymce.urls')), url(r'^mce_filebrowser/', include('mce_filebrowser.urls')), ]

Then I got error: .. _env/local/lib/python2.7/site-packages/mce_filebrowser/urls.py", line 4, in from django.conf.urls import patterns, url ImportError: cannot import name patterns

ghost commented 5 years ago

Hello @alamkaton ! I had same problem, but i think i have fixed it. In my case, problem was in my django version, mce_filebrowser uses url and imports for older versions So i made some editings and all went good I can add img now, so screenshot_20190119_152935


In urls reworked patterns to urlpatterns and using re_path Edited imports to correct form urls.py

from mce_filebrowser import views
from django.urls import re_path

urlpatterns = [
    re_path(r'^image/$',
        views.filebrowser, 
        {'file_type': 'img'},
        name='mce-filebrowser-images'
    ),
    re_path(r'^file/$',
        views.filebrowser, 
        {'file_type': 'doc'},
        name='mce-filebrowser-documents'
    ),
    re_path(r'^image/remove/(?P<item_id>\d+)/$',
        views.filebrowser_remove_file, 
        {'file_type': 'img'},
        name='mce-filebrowser-remove-image'
    ),
    re_path(r'^file/remove/(?P<item_id>\d+)/$',
        views.filebrowser_remove_file, 
        {'file_type': 'doc'},
        name='mce-filebrowser-remove-document'
    )
]

In views deleted outdated import views.py

from django.template import RequestContext
from django.http import HttpResponseRedirect
from django.shortcuts import render_to_response, get_object_or_404
from django.utils.translation import ugettext as _ # i don`t know use of this import, it`s unused. 
from django.urls import reverse
from django.contrib.admin.views.decorators import staff_member_required
from mce_filebrowser.models import FileBrowserFile
from mce_filebrowser.forms import FileUploadForm

Hope this was helpfull

bestrahsaremi commented 5 years ago

I solved my problem by updating urls.py of mce_filebrowser like this:

` from django.urls import path from mce_filebrowser import views

urlpatterns = [ path('image/', views.filebrowser, {'file_type': 'img'}, name='mce-filebrowser-images' ), path('file/', views.filebrowser, {'file_type': 'doc'}, name='mce-filebrowser-documents' ), path('image/remove//', views.filebrowser_remove_file, {'file_type': 'img'}, name='mce-filebrowser-remove-image'), path('file/remove//', views.filebrowser_remove_file, {'file_type': 'doc'}, name='mce-filebrowser-remove-document') ] `

and remove {% load url from future %} from filebrowser.html