search

aishee / sqlalchemy-migrate

Automatically exported from code.google.com/p/sqlalchemy-migrate
MIT License
0 stars 0 forks source link

Migration Support for Sqlite #43

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
I added migration support for sqlite (see the attached file).
Tests run through fine, except from one failure (test_default), where I
don't know exactly what's killing sqlite, as it should support server defaults.

There is only one not_supported='sqlite' decorator remaining:
grep --exclude-dir=.svn -R "not_supported='sqlite'" *
test/changeset/test_constraint.py:    @fixture.usedb(not_supported='sqlite')
(which is test_define_fk, where I don't know how to add them yet)

I get one remaining error, which occurs in postgres too, where I don't know
why this table doesn't exist...

Imo, the patch enables most of the needed features and I would be happy if
it got included.

Cheers, Florian Apolloner

Original issue reported on code.google.com by f.apollo...@gmail.com on 30 Dec 2008 at 8:24

Attachments:

GoogleCodeExporter commented 8 years ago 
One thing I forgot: I don't know what the sqlite related stuff in
http://code.google.com/p/sqlalchemy-migrate/source/browse/trunk/test/changeset/t
est_changeset.py#278
does. So this could mark some test failures?!

Original comment by f.apollo...@gmail.com on 30 Dec 2008 at 8:27

GoogleCodeExporter commented 8 years ago 
Patch is applied in svn trunk r474

Original comment by jan.ditt...@gmail.com on 30 Dec 2008 at 8:44

GoogleCodeExporter commented 8 years ago 
I checked with the guys in sqlalchemy now, the failing test won't work for 
sqlite,
cause it returns ? for the default value, so we can't check whether or not it
accepted the new value, hence add 'sqlite' to not_supported in
http://code.google.com/p/sqlalchemy-migrate/source/browse/trunk/test/changeset/t
est_changeset.py#382
again.

Thx, Florian

Original comment by f.apollo...@gmail.com on 30 Dec 2008 at 9:23

GoogleCodeExporter commented 8 years ago

Original comment by jan.ditt...@gmail.com on 31 Dec 2008 at 9:57

GoogleCodeExporter commented 8 years ago

Original comment by jan.ditt...@gmail.com on 31 Dec 2008 at 9:58

GoogleCodeExporter commented 8 years ago 
No need to add sqlite again, it's fixed in Sqlalchemy, see here:
http://code.google.com/p/sqlalchemy-migrate/issues/detail?id=44

Original comment by f.apollo...@gmail.com on 3 Jan 2009 at 10:10

GoogleCodeExporter commented 8 years ago 
hopefully fixed by depending on SQLAlchemy 0.5 that was released today

Original comment by jan.ditt...@gmail.com on 6 Jan 2009 at 9:58