aishee / sqlalchemy-migrate

Automatically exported from code.google.com/p/sqlalchemy-migrate
MIT License
0 stars 0 forks source link

sqlalchemy-migrate 0.5.1.2 requires sphinx, jinja, pygments #47

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. easy_install sqlalchemy-migrate==0.5.1.2

What is the expected output? What do you see instead?
During installation, sphinx is installed as a requirement. Sphinx's
requirements, Jinja (1) and pygments are also installed.

In previous versions no such requirement existed. It seems that if I'm not
building docs it's unecessary.

What version of the product are you using? On what operating system?
0.5.1.2, Python 2.5.2

Original issue reported on code.google.com by therobot...@gmail.com on 9 Feb 2009 at 10:35

GoogleCodeExporter commented 8 years ago
new docs are built using sphinx, you are right that you don't need it for
building/installing migrate itself.

If I find a way to hint the sphinx requirement without directly depending on 
sphinx
at build time I'll fix this issue.

Original comment by jan.ditt...@gmail.com on 10 Feb 2009 at 8:46

GoogleCodeExporter commented 8 years ago

Original comment by jan.ditt...@gmail.com on 10 Feb 2009 at 8:49

GoogleCodeExporter commented 8 years ago
I wasn't sure if there was a way to recommend a package in setup.py, and after
looking I can't find anything. I took a look through some other projects; 
SQLAlchemy,
Werkzeug, and Jinja2 (trees I happened to have had around) don't require Sphinx
despite using it for docs. As far as I can see they don't mention it anywhere 
in the
tree outside of docs/, even in a README, although that is certainly reasonable.

Just FYI.

Original comment by therobot...@gmail.com on 10 Feb 2009 at 7:14

GoogleCodeExporter commented 8 years ago
Actually, there is a way:
http://peak.telecommunity.com/DevCenter/setuptools#declaring-extras-optional-fea
tures-with-their-own-dependencies

But the intent in that feature is for optional features that require extra 
packages,
not for packages needed for development, so it doesn't line up exactly.

Original comment by therobot...@gmail.com on 10 Feb 2009 at 7:18

GoogleCodeExporter commented 8 years ago
I was able to track this myself and arrived here. This adds another issue when
installing with pip (which uses sdist), this means now sqlalchemy-migrate 
requires a
compiler to build :) 

I'm really not sure what "setup_requires" is for. But it seems to me this is 
wrong.
nose should be a "test dependency" and sphinx not a dependency at all.

for test dependencies see how TG2 handles this, you can use the extra's pointed 
out
at comment 4 or "force" people to use python setup.py test. 

Original comment by jorge.vargas on 13 Feb 2009 at 5:53

GoogleCodeExporter commented 8 years ago
the bug is fixed in svn trunk

Original comment by jan.ditt...@gmail.com on 13 Feb 2009 at 7:23

GoogleCodeExporter commented 8 years ago
Thanks, Jan. I appreciate it.

Original comment by therobot...@gmail.com on 13 Feb 2009 at 7:29