search

aishek / axios-rate-limit

Rate limit for axios
MIT License
237 stars 35 forks source link

rewrite in typescript and shared / distributed locking #39

Open simllll opened 3 years ago

simllll commented 3 years ago

Hi @aishek , thanks for your awesome work, this Pr is not intended for merging as it contains several changes which are not relevant, but it cointains two things that might be of interest for you: 1.) it is a rewrite in typescript 2.) it changes the rate liminting approach to the one of https://github.com/nfriedly/express-slow-down and also allows to plug in the same stores that express-slow-down and express-rate-limit have already, this furthermore allows to use a "reids" or "memcached" store instead of the memory one, which allows to share locks between different processes/instances.

Feel free to cherry pick commits from my fork and bring them back in to the main library :-)!

npm: https://www.npmjs.com/package/@hokify/axios-rate-limit source. https://github.com/hokify/axios-rate-limit

Thanks again

aishek commented 3 years ago

Oh, thank you very much! I need some time to review the changes

buenofs commented 2 years ago

Oh, thank you very much! I need some time to review the changes

Where you able to review the changes @aishek ? I'm currently using this fork to work with Redis but tbh if it were merged to the main project would make it much easier to work with.