aishh12 / pe

0 stars 0 forks source link

Case sensitivity of select command #3

Open aishh12 opened 2 years ago

aishh12 commented 2 years ago

Steps to reproduce bug:

  1. type select 4e2

Expected output: details of all students from the class 4E2

Actual output: error message saying class does not exist

image.png

Reason for bug report : Although it is mentioned in the user guide that the select command is case sensitive, for all practical purposes this is overzealous input validation. In a real life scenario one may enter 4e2 in a hurry and be met with an error message saying that the class doesn't exist. This issue becomes worse if the class names are longer.

nus-pe-bot commented 2 years ago

Team's Response

Thanks for the issue. Firstly, our team don’t think this is an overzealous input validation because we have designed the class names to be case sensitive when they are added into TeachBook, and we would like to use capital and lowercase letters to differentiate the two classes. Furthermore, if you really want to consider this as a feature flaw, we think it is of low severity because this is unlikely to affect teachers’ normal use of the app and only appears in rare situations: 1) under normal situations, teachers can be very familiar with class names, and it is not easy to type wrongly 2) if a user finds a class name is too long/strange to type out, he/she can always edit it to become a simpler one.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response. However, I'd like to disagree with the feature flaw being rejected. For all practical purposes, class names are case-insensitive. To be met with an error message saying that the class to be selected doesn't exist solely because the case differs is not reasonable for a real world scenario. Hence, this feature becomes less useful to the intended target user for normal usage, especially since viewing the class is a feature that'd likely be frequently used.

As stated in the module website :

type.FeatureFlaw: Some functionality missing from a feature delivered in v1.4 in a way that the
feature becomes less useful to the intended target user for normal usage.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: As select is likely to be a frequently used command, this flaw will potentially cause occasional inconvenience to some users but they can continue to use the product. Typing the name of the class in a different case cannot be considered as a very rare case.