search

aishh12 / pe

0 stars 0 forks source link

deleteClass command is case sensitive #6

Open aishh12 opened 2 years ago

aishh12 commented 2 years ago

Steps to reproduce bug:

  1. type deleteClass 4e2

Expected output: message saying that class 4e2 has been deleted

Actual output:

image.png

Reason for bug report : similar to before, deleting a class shouldn't be case sensitive as it will become inconvenient for the user if the class name is too long and even one character is entered with the incorrect case while typing the command.

nus-pe-bot commented 2 years ago

Team's Response

Thanks for the issue. We reject this bug for two reasons: Firstly, we have designed the class names to be case sensitive when the class is added into TeachBook, and we would like to use capital and lowercase letters to differentiate two classes. This implies case sensitivity must be required when deleting a class. Secondly, we think it is the correct behaviour for “deleteClass” to require case sensitivity to prevent users from deleting a class (with all the students) carelessly. However, if you really want to consider this as a feature flaw, we think it is of low severity because it is unlikely to affect teachers’ normal use of the app and only appears in rare situations: 1) a teacher will not use the “deleteClass” frequently 2) under normal situations, teachers can be very familiar with class names, and it is not easy to type wrongly 3) if a user finds a class name is too long/strange to type out, he/she can always edit it to become a simpler one.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response. However, I'd like to disagree with the reasons provided for rejecting this bug. First, in a practical situation, classes aren't case sensitive, so schools won't differentiate between 4E2 and 4e2 (as it refers to essentially the same thing). Since the app is targeted for a school setting, making it case sensitive for operations like delete, does not model a real world scenario well. Hence the argument for case sensitivity preventing careless deleting becomes invalid as well since, there won't be 2 classes different from each other solely based on case.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: With regards to the severity of the bug, the module website provides the following definitions for low and medium severity bugs : 

severity.Low : A flaw that is unlikely to affect normal operations of the product. 
Appears only in very rare situations and causes a minor inconvenience only.
severity.Medium : A flaw that causes occasional inconvenience to some users 
but they can continue to use the product.

For the point : "if a user finds a class name is too long/strange to type out, he/she can always edit it to become a simpler one." - this isn't really up to the teacher if the class codes are longer than 4 or 5 characters.

And for : "under normal situations, teachers can be very familiar with class names, and it is not easy to type wrongly" - it becomes a pain to the user to remember exactly which case he used, since in real life class codes are case insensitive. Hence it would cause occasional inconvenience to some users (especially teachers who are still new and those who are forgetful) but they can still continue using the product.