aisingapore / PeekingDuck

A modular framework built to simplify Computer Vision inference workloads.
Apache License 2.0
163 stars 39 forks source link

feat: allowing users to set the bounding box color and flag to toggle displaying confidence scores on bbox #732

Closed sabrimansor closed 1 year ago

sabrimansor commented 1 year ago
  1. Allowing users to set the bounding box color Closes aisingapore/PeekingDuck-Private#106 For example:

    nodes:
    - input.visual:
    source: 0
    - model.yolox
    - draw.bbox:
    show_labels: True
    color_choice: [229, 255, 0] # [ B, G, R ] Turquoise
    - output.screen
  2. Added a flag to toggle displaying confidence scores on bbox Closes aisingapore/PeekingDuck-Private#108 Usage - in the yml run file:

    nodes:
    - input.visual:
    source: 0
    - model.yolox
    - draw.bbox:
    show_labels: True
    show_scores: True
    - output.screen
liyier90 commented 1 year ago

Perhaps we should consider "Squash and merger" for this PR since there are multiple commits with the same message but different changes. Also because this looks like a collaborative PR so not sure if it will be easy to rebase.

ongtw commented 1 year ago

Perhaps we should consider "Squash and merger" for this PR since there are multiple commits with the same message but different changes. Also because this looks like a collaborative PR so not sure if it will be easy to rebase.

Good idea to use squash and merge to clean up this PR. The commit messages are currently messy with duplicates.

frankcaoyun commented 1 year ago

Perhaps we should consider "Squash and merger" for this PR since there are multiple commits with the same message but different changes. Also because this looks like a collaborative PR so not sure if it will be easy to rebase.

Good idea to use squash and merge to clean up this PR. The commit messages are currently messy with duplicates.

We tried to squash but it's a bit complicated since we have commits in between each other. Will need to do git reset back and forth for several rounds. I decided to just squash the most recent commits before creating the PR. Learnt how to perform the squash and will take note of this for future commits.