aisingapore / TagUI

Free RPA tool by AI Singapore
Apache License 2.0
5.66k stars 585 forks source link

Bug on snap step (Chromium changed) and solution, macOS python fix, new focus step #1350

Closed kensoh closed 3 months ago

kensoh commented 1 year ago

Hi @ruthtxh, a heads-up that there is a bug which I believe exists in newer Chromiums. You can replicate by trying to snap an element that is outside the initial view. Even by hover to the element before snapping it does not work.

I've looked into it and it can be fixed by using absolute instead of relative coordinates, see this commit to the TagUI fork that I maintain - https://github.com/tebelorg/TagUI/commit/7ecc6ab784dc48784d37fb82bfea6469966e9f1c

You can see more context of this bug and replication steps here - https://github.com/tebelorg/RPA-Python/issues/479

See if you want to fix this bug in TagUI. Also newer Macs have problems because there is no python command and only python3 command even after installing. The solution is here, see if you want to update TagUI docs or update the 3 files (which is tricky because you can break Mac users with python but no python3) - https://github.com/tebelorg/RPA-Python/issues/477

I've also added a new function focus() for Python rpa package to make an application window in foreground in focus - https://github.com/tebelorg/RPA-Python/issues/478 but I recall that you are not planning to add new features, so fyi

kensoh commented 3 months ago

Closing because not raised by any user, can reopen if issue reported by user.

kensoh commented 2 months ago

Linking to solution used for Python rpa package - https://github.com/tebelorg/TagUI/commit/7ecc6ab784dc48784d37fb82bfea6469966e9f1c

Will wait for users to raise issue before patching. Otherwise might break users' scripts with this new behaviour to work around Chromium's new behaviour