Closed J3ldo closed 3 weeks ago
Also in issue #29
I think it's better to add it as an attribute of Option
Hi @aisk , It seems like the person who originally opened this PR, isn't interested anymore. Are you planning on fixing and merging it?
@iamalisalehi This change looks almost good to me with what you pointed out. But some work can't be done just by clicking the submit button in your reviews above, like adding a field to the Options
class.
So I think we need to create a new PR to continue the work. And if you are interested in it, you can just do it, but one thing to note is that, if you want to use the code in this PR, it should keep the commits in this PR, or add the original author to the co-author field in commit messages, to appreciate their contributions.
Added excluded indexes, excluded indexes are put in as a list and will be skipper over when tried to select. An user may need this for file selection to make the directories unselectable.
Code added: