search

aisk / rust-memcache

memcache client for rust
MIT License
132 stars 41 forks source link

Fractional timeouts #134

Closed plicease closed 1 year ago

plicease commented 1 year ago

It would be useful to have the option to set sub second timeouts, the memcache client that I had been using in another language had this feature. The Duration struct supports sub second duration, assuming the network libraries and connection manager do also I think this would be mostly a matter of figuring out how to specify milliseconds instead of seconds.

plicease commented 1 year ago

I've confirmed that that the connect timeout will work with millisecond timeouts. I did this by using f64 instead of i64 in #133 and running it against my code with a timeout of 0.2. I doublechecked that a timeout of 5 for example still did what I expected as well.

An alternative would be I guess to recognize a suffix 200ms as being miliseconds or something like that but it seems more complicated?

plicease commented 1 year ago

Thanks for the timely deploy 0.17.0 this is resolved.