aisouard / libwebrtc

:package: Google's WebRTC implementation in a single static library.
https://axel.isouard.fr/libwebrtc
Apache License 2.0
641 stars 190 forks source link

You might not want to pass -j to ninja #34

Closed agouaillard closed 7 years ago

agouaillard commented 7 years ago

it is internally multithreaded and is doing a good job at finding the maximum number of thread. Passing -j should then only be used to reduce the number of thread ninja would normally use, in case you are using the computer to do something else. Any number passed above the optimal number would result in decreased performance. The -j option is dangerous ...

aisouard commented 7 years ago

I felt that it was speeding up builds under Travis, it is in fact useless and dangerous to set it on a personal computer. Removed in the README.