search

ait-energy / qgis-edge-bundling

GNU General Public License v2.0
63 stars 14 forks source link

Check data and log if not compatible #11

Closed spatialsparks closed 6 years ago

spatialsparks commented 6 years ago

logs into python console, better would be to progress window..? Have a look if it works, for me it seems to be working for a small dataset :)

anitagraser commented 6 years ago

Sorry, this PR slipped my mind!

Is there a particular reason for the way you implemented the check if there are more than two vertices? Wouldn't edges_as_vect[e_idx].length() do the trick?

spatialsparks commented 6 years ago

Hi! Well, I am pretty new to QGIS plugins and so there is no particular reason for how I implemented it. Its just the way I thought was easiest. But your suggestion sounds like it might work far better and be more readable in the code :)

anitagraser commented 6 years ago

I see. I'll close this PR and implement the checks in the new plugin code base. Thank you for sharing!