aitjcize / PyTox

Python binding for Project-Tox the skype replacement.
GNU General Public License v3.0
96 stars 29 forks source link

Python aborts when friend comes online using Antidote client #62

Closed aserranoh closed 7 years ago

aserranoh commented 7 years ago

When a friend comes online using the Android Antidote client, it sends a file of type TOX_FILE_KIND_AVATAR, but with filename = NULL and filename_length = 0. Then, the assertion in the file core.c line 141:

assert(TOX_HASH_LENGTH == filename_length);

fails, and python aborts. Isn't that assertion restricting cases that the tox protocol accepts?

GrayHatter commented 7 years ago

That assert is incorrect; an avatar with file size 0 means avatar deleted. (or never existed)

kitech commented 7 years ago

Oh, thanks