search

aitjcize / cppman

C++ 98/11/14 manual pages for Linux/MacOS
GNU General Public License v3.0
1.29k stars 81 forks source link

Migrate to Python3 #40

Closed czchen closed 9 years ago

czchen commented 9 years ago

This pull request migrate cppman to Python3.

aitjcize commented 9 years ago

I actually want cppman to work with both python2 and python3. Do you think that's a good idea?

czchen commented 9 years ago

I am not sure if it is necessary to support both python2 and python3 at the same time for an application. However, If support both python2 and python3 at the same code base is needed, maybe we can use six to do so. I do not use six before, but the API document seem to address most of the code changed by 2to3.

Also, we need to setup tox to easily test code in both python2 and python3 at the same time. I will to a PR for tox later.

aitjcize commented 9 years ago

Yes you have a point, since we are just an application. It really doesn't matter how it's implemented. I'm going to merge this PR into a testing branch. Can you fixup the things I mentioned in the commits? Thanks a lot!

czchen commented 9 years ago

All the comments are fixed. Please help to test it, thanks.

aitjcize commented 9 years ago

Pushed into the python3 branch for now. I'll do more testing this week, if everything is fine I'll merge it into master. (Merging into other branch doesn't seem to close the PR)

TheJJ commented 9 years ago

I'd also be interested in seeing cppman support python 3. How's the status of this now?

aitjcize commented 9 years ago

This seems to be stable enough.

czchen commented 9 years ago

@aitjcize Please release a new version for this so that others can help to test if there is any problem in Python3.

aitjcize commented 9 years ago

Yes I was about to do that.

aitjcize commented 9 years ago

version 0.4.5 released