search

aitoss / Anubhav-frontend-23

Anubhav: Experience Sharing Point (A-ESP) is a platform developed for AITians to read & share encounters of various interviews.
https://anubhav.aitoss.club/
MIT License
4 stars 12 forks source link

Updated CONTRIBUTING.md #40

Closed Bharathhh30 closed 6 days ago

Bharathhh30 commented 1 week ago

i have made changes to the contributing.md with the mentioned points by you

I went through whole code base , i was just amazed by the file structure and the front end design is at peaks (it was one of best i saw ) , i use to do all small projects , small components and ..... but this code has motivated me a lot bro . I am currently in the process of learning react , and will try to contribute via code too

this is my first pr , if any mistakes in the contributing.md please let me know brother

Thank You : )

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
anubhav-frontend-23 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 0:23am
Lokendrakushwah12 commented 1 week ago

Looks good to me but you forgot to mention that people can raise issue if they find any bug and create PR for it so do write the format for creating an issue

404Nikhil commented 1 week ago

@Bharathhh30 good work, but few changes

1) change the product url to https://anubhav.aitoss.club/ 2) remove yarn instructions, as we have only used npm in the whole project plus there's no yarn.lock in the main project. We will add it later.

Bharathhh30 commented 1 week ago

Okay will make the changes mentioned by you

Hey the changes mentioned have been made : )

Is there anything still to be done ?