search

aivazis / config

10 stars 2 forks source link

cython requires numpy #1

Closed piyushrpt closed 6 years ago

piyushrpt commented 6 years ago

cython by default requires -I NUMPY_INCDIR as it builds interface to lists as well as numpy arrays. Numpy can be self discovered using "import numpy; numpy.get_include()" once the version of python has been finalized.

aivazis commented 6 years ago

Any idea what happens on machines that don’t have numpy installed? I don’t typically install numpy on my computers, yet somehow python seems to build extensions successfully. Is this consistent with what you know about the problem?

— Michael

On May 31, 2018, at 6:27 PM, piyushrpt notifications@github.com wrote:

cython by default requires -I NUMPY_INCDIR as it builds interface to lists as well as numpy arrays. Numpy can be self discovered using "import numpy; numpy.get_include()" once the version of python has been finalized.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aivazis/config/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AGCCyQzvuplBhAqSWrPShqSgjX3qOKP9ks5t4AvVgaJpZM4UVQPI.

piyushrpt commented 6 years ago

True. The use case is very specific to the way we are trying to build extensions. Support for automatic translation from lists to numpy arrays - and vice versa automatically becomes available to the user when numpy support is turned on. Using numpy is optional, but the majority of users will use the numpy interface for anything that involves arrays or images.

piyushrpt commented 6 years ago

Agreed. This is not a relevant issue. In our cmake files, we explicitly add NUMPY_INCLUDE_DIR and dont force cython to use it all the time.

aivazis commented 6 years ago

We should take care of this in the local Make.mm. I’ll try to make it easier by adding numpy support to config. Stay tuned.

-- Michael

On Jul 12, 2018, at 5:52 AM, piyushrpt notifications@github.com wrote:

Closed #1.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.