Support specific error code for version mismatch on migration - Githubissues

aiven / aiven-db-migrate

Apache License 2.0

21 stars 10 forks source link

Support specific error code for version mismatch on migration #30

Closed ghost closed 2 years ago

ghost commented 2 years ago

Proposed changes in this pull request

Add a "reason" attribute to migration error to allow the caller to precisely identify why the migration check failed
Currently support migrations that fail because of a version mismatch (target server older than source); other reasons and better parsing logic will be added later on.

Type (put an `x` where ever applicable)

[ ] Bug fix: Link to the issue
[X] Feature (Non-breaking change)
[ ] Feature (Breaking change)
[ ] Documentation Improvement
[ ] Other

Checklist

Please put an x against the checkboxes. Write a small comment explaining if its N/A (not applicable)

[X] All the tests are passing after the introduction of new changes.
[X] Added tests respective to the part of code I have written.
[ ] Added proper documentation where ever applicable (in code and README.md).

Optional extra information

Tested with postgresql 9.6 and beyond.

ghost commented 2 years ago

After a discussion with @kmichel-aiven we're dropping this right now; a (possible) re-engineering of this API will be discussed later on.