aiven / terraform-provider-aiven

Aiven Terraform Provider

https://registry.terraform.io/providers/aiven/aiven/latest/docs

MIT License

126 stars 69 forks source link

fix(flink_application_deployment): wait for state on creation and deletion #1606

Closed Serpentiel closed 6 months ago

Serpentiel commented 6 months ago

Merge this PR instead of squashing it!

About this change—what it does

fixes faulty sql in flink application deployment tests
adds a test that checks for an error that should be returned when a deployment configuration is attempted to be created
adds a wait for state on creation of flink_application_deployment
adds a fault-proof logic for deleting the flink_application_deployment (there are some states during which neither Delete or Cancel will succeed, this is accounted for in this PR)

Why this way

it misbehaves at the moment

byashimov commented 6 months ago

I don't think implementing the whole proprietary state machine is a good idea. It is just pure over-engineering to me.

Serpentiel commented 6 months ago

proprietary state machine

Apache Flink is Open Source...

implementing the whole proprietary state machine is a good idea

There's no state machine in this PR. There's a map of possible state transitions, but the actual transitions happen on the backend side. We simply are checking what can we do with the states that were returned to us by the backend, to avoid doing things that aren't allowed. I would call it a state-tracking mechanism instead, because we don't produce any states and only operate based on the existing ones.

Serpentiel commented 6 months ago

tests: https://github.com/aiven/terraform-provider-aiven/actions/runs/8006248227

Serpentiel commented 6 months ago

Closing in favor of #1611