aiverify-foundation / aiverify

AI Verify
https://aiverify-foundation.github.io/aiverify/
Apache License 2.0
111 stars 33 forks source link

[FEATURE] Restrict Redis version to <7.4 #277

Open timlrx opened 5 months ago

timlrx commented 5 months ago

Is there an existing issue for this?

Description

Heads up that Redis is also moving to a restrictive proprietary license starting from v7.4 onwards.

Suggest to restrict the version to <7.4

Is your feature request related to a problem/limitation?

Licensing issue which limits adoption and use of the software

Describe the solution you'd like

Given the dependencies to redis and the use of the subscription feature, my recommendation would be to just restrict the version for the time being.

Alternatives

Replace with an open-source Redis alternative that supports subscription.

Additional Context

No response

Related Issues/PRs

276

imda-benedictlee commented 1 month ago

Hi @timlrx, thanks for flagging this to our attention. Let me bring to the attention of the team for further discussion on where to take this.

imda-benedictlee commented 1 month ago

@HanFai-IMDA for your attention.

timlrx commented 1 month ago

Thanks @imda-benedictlee and @HanFai-IMDA! Another possibility is to use https://github.com/valkey-io/valkey which is the linux foundation fork of redis that seems to be getting the most traction. It has more contributors and recent activity compared to redis - https://github.com/valkey-io/valkey/pulse/monthly vs https://github.com/redis/redis/pulse/monthly

imda-benedictlee commented 1 month ago

Hi @timlrx, thanks for the suggestion. I think at the moment, we could go with the first suggestion to fix the version below 7.4. Will bring up the alternatives to a discussion with the team.

HanFai-IMDA commented 1 month ago

Noted on the change in Redis license from v7.4 onwards. Currently AI Verify install Redis server version 6.2 in the docker compose and k8s scripts. We will lock it at version 6.x until the release of AI Verify 2.0. As for the Redis clients used by the python and nodejs modules, they are licensed under MIT and not affected by Redis change in licensing.