aiverify-foundation / moonshot-data

Contains all assets to run with Moonshot Library (Connectors, Datasets and Metrics)
Apache License 2.0
11 stars 9 forks source link

[MS-294] Removal of attack modules field in all recipes #69

Closed imda-lionelteo closed 1 month ago

imda-lionelteo commented 1 month ago

Description

Removal of attack modules field in the recipe

Motivation and Context

Remove the attack module because it is no longer required for augmented benchmark. Previously this is needed as dynamic benchmarking runs the dataset and pass the dataset prompt to the attack modules that are defined in the recipe.

Now, this is not needed because there is another path that will augment and save it as a new dataset and recipe before it will run the benchmarking.

Type of Change

How to Test

This is a sub-test that needs to be tested with MS-292 to ensure that it will still run properly.

Checklist

Please check all the boxes that apply to this pull request using "x":

Screenshots (if applicable)

[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]

Additional Notes

This is a sub-test that needs to be tested with MS-292 to ensure that it will still run properly.

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
imda-benedictlee commented 1 month ago

Link to Jira Ticket: https://imda-dsl.atlassian.net/browse/MS-294?atlOrigin=eyJpIjoiNWNmYjg3OTFiMzFiNDllOTllNTQ1NWZiZDQyNzkyODQiLCJwIjoiaiJ9

imda-benedictlee commented 1 month ago

Tested. Working as expected.

Screenshot 2024-07-31 at 4 59 32 PM