aiverify-foundation / moonshot-data

Contains all assets to run with Moonshot Library (Connectors, Datasets and Metrics)
Apache License 2.0
18 stars 17 forks source link

[MS-432] Fix range bug #86

Closed imda-lionelteo closed 2 months ago

imda-lionelteo commented 2 months ago

Description

AdvGLUE recipe has: 0 prompt template 1 dataset with 721 prompts User input 200, ran 199

Winobias recipe has: 0 prompt template 1 dataset with 396 prompts User input 200, ran 199

Motivation and Context

This is a range bug. There are 2 issues found.

When user types 20 prompts, the dataset has 5. By right it should range from 0, 1, 2, 3, 4. But the error will do a range 1, 2, 3, 4, 5, it will skip the first prompt and have an issue with index on the last value. Hence 4/5.

When user types 3 prompts and the dataset has 5. By right it should contain exactly 3 unique numbers from the set {0, 1, 2, 3, 4}. But the error will have a range will contain exactly 3 unique numbers from the set {1, 2, 3, 4, 5} where 5 is invalid and missing the first index.

Type of Change

How to Test

Run easy test with 200 prompts

Checklist

Please check all the boxes that apply to this pull request using "x":

Screenshots (if applicable)

Screenshot 2024-08-20 at 9 13 39 PM Screenshot 2024-08-20 at 9 13 25 PM Screenshot 2024-08-20 at 9 13 33 PM

Additional Notes

[Add any additional information or context that might be relevant to reviewers.]

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
imda-benedictlee commented 2 months ago

Jira Tickets: