This change would allow user to reinstall moonshot-data and -ui in unattended mode.
Motivation and Context
This is to allow more flexibility to support CICD pipelines
Type of Change
How to Test
You can test this with either moonshot-ui or moonshot-data or both.
You can freshly install moonshot-ui or moonshot-data.
After installing for the first step, run the same installation command. You should be able to see the prompt Y/n to replace existing folder or not.
If you press n, if it continue on with installing the requirements without replacing your existing folder.
If you press Y, it would remove the existing folder and install the new repo and requirements.
You can now try running the installation with the -o flag. (e.g. python -m moonshot -i moonshot-data -o, it will remove the existing folder and reinstall the new repo and requirements without asking for user input.
You can now try running the installation with the -u flag (e.g. python -m moonshot -i moonshot-data -u. You will see a message that says "Unattended mode detected. To reinstall, please use the --overwrite flag." . And it will proceed with installing the requirements.
You can now try running the installation with both the -o and -u flag (e.g. python -m moonshot -i moonshot-data -u -o. It will now remove the existing folder and reinstall the new repo without asking for user input. And also reinstall the new requirements.
Checklist
Please check all the boxes that apply to this pull request using "x":
[x] I have tested the changes locally and verified that they work as expected.
[x] I have added or updated the necessary documentation (README, API docs, etc.).
[ ] I have added appropriate unit tests or functional tests for the changes made.
[x] I have followed the project's coding conventions and style guidelines.
[x] I have rebased my branch onto the latest commit of the main branch.
[x] I have squashed or reorganized my commits into logical units.
[x] I have added any necessary dependencies or packages to the project's build configuration.
[x] I have performed a self-review of my own code.
[ ] I have read, understood and agree to the Developer Certificate of Origin below, which this project utilises.
Screenshots (if applicable)
[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]
Additional Notes
[Add any additional information or context that might be relevant to reviewers.]
Developer Certificate of Origin
```
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
```
imda-lionelteo
commented
1 week ago
Description
This change would allow user to reinstall moonshot-data and -ui in unattended mode.
Motivation and Context
This is to allow more flexibility to support CICD pipelines
Type of Change
How to Test
You can test this with either moonshot-ui or moonshot-data or both.
python -m moonshot -i moonshot-data -o, it will remove the existing folder and reinstall the new repo and requirements without asking for user input.python -m moonshot -i moonshot-data -u. You will see a message that says"Unattended mode detected. To reinstall, please use the --overwrite flag.". And it will proceed with installing the requirements.python -m moonshot -i moonshot-data -u -o. It will now remove the existing folder and reinstall the new repo without asking for user input. And also reinstall the new requirements.Checklist
Please check all the boxes that apply to this pull request using "x":
Screenshots (if applicable)
[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]
Additional Notes
[Add any additional information or context that might be relevant to reviewers.]
Developer Certificate of Origin
``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```