search

aiwc / test_world

AI World Cup simulation environment
MIT License
7 stars 12 forks source link

Simplified cross-platform compatibility #18

Closed omichel closed 6 years ago

omichel commented 6 years ago

Here is a suggestion to simplify cross-platform compatibility. Thanks to this change, there is no need to maintain two different versions of the world file. That's easier for the users and will also simplify the documentation.

👍

chshong commented 6 years ago

Hello, I have checked your modifications and I think there should be one additional modification. Since we are allowing the participants to use python script on Windows, we may need to take care of the case when the executable path ends with '.py'.

chshong commented 6 years ago

Also, can you send us a pull request to our 'develop' branch instead? We are keeping modifications in 'develop' branch before modifying the master branch. Thank you.

omichel commented 6 years ago

Good point. I will handle the .py case and target your develop branch.