aiwc / test_world

AI World Cup simulation environment
MIT License
8 stars 12 forks source link

Simplify cross-platform compatibility #20

Closed omichel closed 6 years ago

omichel commented 6 years ago

Replaces #18, taking into account Python controllers and targeting the develop branch of aiwc/test_world.

👍

chshong commented 6 years ago

Thinking about using config.json to provide the executable path, it can be possible that adding ".exe" automatically may confuse the windows users now. So I am thinking of dropping that part and inform the users how to use the configuration file instead.

omichel commented 6 years ago

Alternatively, we could support both cases on Windows:

That would be more robust and allows (in the second case) to have a config.json file that is cross-platform while the first case is easier to understand for users.

But if you prefer to totally drop the second case, this is also fine. It should not raise any particular problem.

chshong commented 6 years ago

I will try your suggestion and notify you when the change is made.

chshong commented 6 years ago

While I was testing the system in Windows, I found that our AI world cup simulation is capable of running an Windows executable program even if the program lacks ".exe" extension or having any other extensions such as ".rar" (It seems boost::process used for running the user program as a child process is allowing it).

Now my concern is that a user may try to make a participant executable program that does not have ".exe" extension (which will actually work in our simulation) and our supervisor would automatically attach ".exe" to the program path and output "no such file or directory".

omichel commented 6 years ago

In that case, I believe we should remove the automatic adding of the ".exe" extension from the supervisor and it will work in both cases (when the user specifies a "controller.exe" or a "controller" file).

chshong commented 6 years ago

I see. Then, current develop branch will be good to proceed signing the world file.

omichel commented 6 years ago

Yes, I will do it today.