aiyanbo / sbt-dependency-updates

⬆️ SBT plugin that can check Maven and Ivy repositories for dependency and plugin updates
Apache License 2.0
81 stars 10 forks source link

Fix certain Version qualifiers from unintentionally being marked unreleased #6

Closed thadeusb closed 6 years ago

thadeusb commented 6 years ago

depedencyUpdates command does not work when using git branch name qualifiers. We have branches for various environments such as "1.1.2-prod", "1.3.6-marketing", "3.2.1-development" managed by bintray or artifactory.

Since "prod" contains pr, it is marked as unreleased and upgraded to 1.1.2. "marketing" contains an "m" so it is marked as unreleased. "development" contains an m as well so it is also marked as unreleased.

What we need is for the prod qualifier to stick when using dependencyUpdates instead of it being lost.

I would suggest that if the qualifier actually matches an element in this list instead of just containing the string would be a better way of automatically marking a version as unreleased, aside from making it an argument that we can override with the sbt config (which is more time to implement that may be necessary)

Versions.UNRELEASED = "pr", "m", "beta", "rc", "alpha", "snapshot", "snap"