search

aizvorski / h264bitstream

A complete set of functions to read and write H.264 video bitstreams, in particular to examine or modify headers.
GNU Lesser General Public License v2.1
713 stars 237 forks source link

Problem with installed headers #10

Closed dv1 closed 7 years ago

dv1 commented 8 years ago

With the latest master, when I run make install, the headers are placed in the root include directory (for example, /usr/include/ ). Also, bs.h is not installed, even though both the h264bitstream headers themselves and programs using h264bitstream need it.

So I suggest to install the headers in a h264bitstream/ subdirectory instead, and also install bs.h. Installing them in a subdirectory keeps the root include directory cleaner, and also prevents name collisions ("bs.h" sounds fairly generic).

aizvorski commented 7 years ago

I agree the missing bs.h is a problem and the proposed solution (subfolder) is good.

@antoneliasson did a pull request which does that and I merged it, closing this.