search

aj-bagwell / clio

A rust library for parsing command line file name arguements
13 stars 8 forks source link

feat: extend MRSV to 1.63 #19

Closed aljazerzen closed 1 year ago

aljazerzen commented 1 year ago

Closes #https://github.com/aj-bagwell/clio/issues/13

Adds alternative implementation of add_extension function, which is slightly less efficient as it clones the path instead of mutating it.

This does add a dependency to rustversion for conditional compilation depending on Rust version. If that is not desired, add_extension function can be replaced completely.

aljazerzen commented 1 year ago

I've removed the rustversion dep and the old function.

I've also updated it to pass all tests and return correct result. There a bit of duplication, but it was required due to different types.

aj-bagwell commented 1 year ago

Thanks for all your work, I have merged it and published it in version 0.3.3