aj-r / RiotNet

A .NET/C# client for the Riot Games API
MIT License
23 stars 10 forks source link

Update API to V4 #31

Closed dfernandezramos closed 5 years ago

dfernandezramos commented 5 years ago

Since some models affect different test classes I've done a single PR separating each endpoint group/endpoint tests class by commits.

dfernandezramos commented 5 years ago
dfernandezramos commented 5 years ago

Changes processed. I'll merge the fixup commits with each proper commit after approve 👍

dfernandezramos commented 5 years ago

All changes processed. Since your last changes request were two typos, I've already merged the fixup commits with their respective ones. 👍

dfernandezramos commented 5 years ago

Please let me know if you need something else. I assume you will merge this PR when you can.

aj-r commented 5 years ago

Everything is fine, I just wanted to double-check that you were merging to the right branch first (which I can't do on my phone for some reason). Looks good!