search

aj-r / RiotNet

A .NET/C# client for the Riot Games API
MIT License
22 stars 10 forks source link

Missing StatPerk in MatchParticipantStats #38

Open joopip opened 5 years ago

joopip commented 5 years ago

Please add StatPerk0, StatPerk1 and StatPerk2 to wrapper.

aj-r commented 5 years ago

I don't see any StatPerk properties in the documentation: https://developer.riotgames.com/api-methods/#match-v4/GET_getMatch. Are you referring to perk0, perk1, perk2, etc.? Or are these some new properties that Riot hasn't documented yet?

joopip commented 5 years ago

These are new properties not documented, related to 3rd runes reforged path (stats rune). Example: ... "participants": [ { "stats": { ... "neutralMinionsKilledTeamJungle": 0, "visionScore": 26, "magicDamageDealtToChampions": 1384, "largestMultiKill": 2, "totalTimeCrowdControlDealt": 467, "longestTimeSpentLiving": 1199, "perk1Var1": 712, "perk1Var3": 0, "perk1Var2": 240, "tripleKills": 0, "perk5": 8473, "perk5Var1": 548, "perk5Var3": 0, "perk5Var2": 0, "totalScoreRank": 0, "neutralMinionsKilled": 4, "statPerk0": 5005, "statPerk1": 5008, "statPerk2": 5001, ... }, } }] ...

Yannick183 commented 5 years ago

I made a PR (#41) that fixes this issue.