search

aj-r / RiotNet

A .NET/C# client for the Riot Games API
MIT License
23 stars 10 forks source link

RiotNet.Test / RiotClientTests.cs / GetServerName_ShouldBeDefinedForAllRegions() is wrong #7

Closed morbalint closed 7 years ago

morbalint commented 7 years ago

RiotNet.Test / RiotClientTests.cs / GetServerName_ShouldBeDefinedForAllRegions() tests for platformId. It should test for serverName. example correct implementation (too lazy for pull request XD, and idk if u even care about this anymore): 

[Test]
public void GetServerName_ShouldBeDefinedForAllRegions()
{
    foreach (string server in from Region region in Enum.GetValues(typeof(Region)) select RiotClient.GetServerName(region))
    {
        Assert.That(server, Is.Not.Null.And.Not.Empty);
    }
}
aj-r commented 7 years ago

Good catch - thanks!