search

aj00200 / BBot

BBot is a Python IRC bot which aims to be fast, modular, and offer a great API!
http://www.aj00200.org/projects/bbot/index.htm
7 stars 4 forks source link

Installer uses subprocess which is not portable #11

Closed KamilaBorowska closed 12 years ago

KamilaBorowska commented 12 years ago

I have done few small changes to BBot which make "bbot-makeconf" script no longer use subprocess Python module to run programs. This makes it work better on Windows, where it's somewhat unlikely to find 'touch' utility.

teward commented 12 years ago

@GlitchMr:

Can you confirm the bbot-makeconf script AND the modifications to config.py still work with the given changes? To be more precise, did you test this on an Ubuntu system to make sure it works correctly and doesn't break anything (so that the packages can be updated)

teward commented 12 years ago

Reassigned to @aj00200

KamilaBorowska commented 12 years ago

Windows supports pathes with / in all APIs in most cases.

C:\Users\GlitchMr>cd C:/Windows\System

C:\Windows\system>

I don't know why Windows allows to use both characters. But I guess I can add os.path.join...

Kudu commented 12 years ago

I looked over all of the changes and, apart from what I pointed out in the r1279865 line note, everything seems OK. I might do some testing soon.

Kudu commented 12 years ago

I did some testing and this seems to work perfectly, apart from the issue that I mentioned previously, which I fixed in 9de5e7a.