search

aj0strow / espn-scraper

a simple gem for scraping teams and scores from ESPN
32 stars 23 forks source link

Game type (pre-season vs regular season) #12

Open benpackard opened 6 years ago

benpackard commented 6 years ago

I'm not sure if this is easily available in the source data but it would be helpful to know whether each score is for a preseason/regular season/postseason game.

dgmdan commented 6 years ago

I've been wanting this too and started working on it on a branch: https://github.com/aj0strow/espn-scraper/compare/season-type-and-game-status The branch also gets the game status (scheduled, in progress, completed). I have some work remaining on it. I was having a hard time getting that data for NHL scores since we scrape in a bit of a sloppier way there (in winner_loser_parse). I was also struggling to come up with a way to add tests for things like in progress scores, since we can't always expect a live game to be going on in every sport when running tests. I plan on working on it again in the next few weeks but if you're interested, feel free to pick up where I left off and open a PR.

bakerjalexander commented 6 years ago

If you can determine whether or not a game is in progress, is it possible to return a period and time-left for those games as well?

dgmdan commented 6 years ago

@bakerjalexander I'll aim to include that, although I don't need it personally. I don't think it will be too much extra work. Thanks for the feedback.