aj3423 / SpamBlocker

Android Call/SMS blocker.
MIT License
411 stars 22 forks source link

v3.2 v3.1 old issue #157

Open Umotas opened 1 day ago

Umotas commented 1 day ago

I uninstall app, and re-install. (1) New (created) WorkFlows don't save (maybe 'Save' freezed) (2) Testing 'Read file' is not working. Failed: Readfile: java.io.FileNotFoundException: /storage/emulated/0/Download/spam.csv: open failed: EACCES (Permission denied)

But Import rules from file works well.

aj3423 commented 1 day ago
  1. Is the "Save" button green or grey? If it's grey, it means there is still some error with this workflow. For example:

    • the actions can't chained together, there're red dots in between
    • if the schedule is "periodically" and the time is 00:00, which would lead to a infinite loop.
  2. After a reinstalling, the file permission is disabled by default, you need to enable it again, by opening that workflow and click the "Save" button. When saving a workflow, it will check all permissions that required.

But Import rules from file works well.

Manually importing rules with the sysytem file chooser is different, it doesn't require any permission, because the user is involved in this operation and the system file chooser will grant the permission for you.

Umotas commented 1 day ago

Is the "Save" button green or grey?

Grey. I understand problem (maybe there is no problem): New (created) WorkFlow must (!) have 'Schedule -> Enable' After this, App saves WorkFlow and App asks Permission for getting files. And app works well.

aj3423 commented 1 day ago

Ah, this is a bug.. It should be able to save a new workflow, I'll fix it later.

Umotas commented 1 day ago

from v3.1 virustotal shows 1 Android.Malware. Previous versions haven't this.

P.S. Ver3.2 without internet is also.

aj3423 commented 1 day ago

Does it show any details about the malware?

Umotas commented 1 day ago

Does it show any details about the malware?

No, only this: Trustlook Android.Malware.General (score:8) https://www.virustotal.com/gui/file/f2ebe263cfe2ee49a61f6cdd887fb06531d38a0ef0fc9105963a86bc27820e94 But there is only one from all other 67 checkers v2 hasn't this.

Umotas commented 1 day ago

Do you change app's signature? I see many apps have such Trustlook's flag or Executing workflows is activities (without user). Maybe this is.

aj3423 commented 1 day ago

Nowadays antivirus software don't even need to tell what exactly the virus is... The app signing key never changes. It's the permissions introduced in v3.0, that version should've been reported malware as well.

Umotas commented 1 day ago

as for me, good ideas are: (1) to display next time execution for each workflow. Now I see a period 40 min and all. I don't know what is next /near time. (2) to make for WorkFlows open/close feature. (As it is for rules, quick copy)

aj3423 commented 1 day ago
  1. It will be 40 min after you press the "Save" button, I'll add a context menu item to show the next tick.
  2. Will add this.
aj3423 commented 16 hours ago

Done: https://github.com/aj3423/SpamBlocker/actions/runs/11426367262

Umotas commented 16 hours ago
  1. I reinstall app. The app doesn't save my first created WorkFlow,but asks permission, tests workflow well and saves second, third workflow. I think there is working well. Thanks
  2. I can open/close the section 'WorkFlows' Thanks
  3. My first workflow has period 45 min. I always see 00:45:00 by long tap. My second workflow has period 1h I always see 01:00:00 Is it countdown time for next execution?

I had hope there will be or coundown time or time for next execution this workflow. Now there is static time = setted period

aj3423 commented 16 hours ago

Is the countdown not working? it should update every second. Is it this action? https://github.com/aj3423/SpamBlocker/actions/runs/11426367262ne: https://github.com/aj3423/SpamBlocker/actions/runs/11426367262

aj3423 commented 15 hours ago

Oh I see, there is problem with the Periodically schedule.