search

aja-video / libajantv2

Open-source library for AJA Video Systems desktop IO cards.
MIT License
22 stars 14 forks source link

Positioning of 'ntv2linuxdriverinterface.h' relative to other includes #22

Open zerodefect opened 4 months ago

zerodefect commented 4 months ago

I'm building v17.0.1 of the ntv2 library released on March 9th, 2024.

I build the SDK as follows:

cmake -DCMAKE_BUILD_TYPE=RELWITHDEBINFO -DAJA_NTV2_SDK_BUILD_NUMBER=$AJA_NTV_PKG_RELEASE -DAJA_INSTALL_HEADERS=ON -DAJA_INSTALL_SOURCES=OFF -DAJA_INSTALL_MISC=OFF -DAJA_INSTALL_CMAKE=OFF -DAJANTV2_DISABLE_DEMOS=ON -DAJANTV2_DISABLE_TOOLS=ON -DAJANTV2_DISABLE_TESTS=ON -DAJANTV2_DISABLE_PLUGINS=ON ..
make

Subsequently, I use checkinstall to create an internally-distributable .dpkg. I notice that the location of where the ntv2linuxdriverinterface file is positioned upon install is quirky and is not in line with what I'd expect.

So ntv2card.h makes an include of ntv2linuxdriverinterface.h however, the include doesn't take account of relative locations (nor directory nesting).

Screenshot from 2024-07-02 10-55-16

I'm not sure if AJA_INSTALL_CMAKE will make things easier, but I don't want cmake to be a forced dependency on other code projects.

This is being built on Ubuntu v22.04.

thomas43 commented 3 months ago

Hi @zerodefect , letting you know that we are discussing this issue as well as #23 with the team. Should have an update soon.